Sebastian Falbesoner
Sebastian Falbesoner
> > The one thing I'm a bit unsure about is that this duplicates quite a lot of code, especially in complete_handshake - the main implementation in v2_p2p.py and the...
> > remove unused cpp-subprocess options > > Are all remaining options used? From the 12 available cpp-subprocess options we currently only use 4 (namely `executable`, `input`, `output` and `error`):...
Thanks a lot for you feedback @laanwj, @hebasto, I've now removed support for all options that we don't use. Especially for the environment option, lots of Windows-specific code can be...
Force-pushed with the last commit changed to tackle https://github.com/bitcoin/bitcoin/pull/29865#discussion_r1571141464. Diff to the previous version ```diff diff --git a/src/util/subprocess.hpp b/src/util/subprocess.hpp index c7f9a685d1..a85c0b0bff 100644 --- a/src/util/subprocess.hpp +++ b/src/util/subprocess.hpp @@ -1210,8 +1210,6 @@...
Concept ACK, thanks for fixing!
FWIW, in a first quick test I couldn't reproduce this issue on signet with the latest version of the master branch. Sure, deriving hundreds of thousands of addresses and marking...
> In order to reproduce you need to create a transaction to that `777777` derived address and make sure it was confirmed on the blockchain and added to your newly...
Concept ACK