Sebastian Falbesoner
Sebastian Falbesoner
Concept ACK Another instance in the tests which could be adapted to 0xffffffff: https://github.com/bitcoin/bitcoin/blob/717103bccec8d271f61f9cd6481b334bd9889146/src/test/transaction_tests.cpp#L783 Slightly related to this PR: since this currently doesn't produce a warning, was it ever considered...
> I think it would be better if the new format could include a version number so that this could be properly reported. If we decide to do that, I'd...
FWIW, I started working on replacing boost::process with cpp-subprocess on the following branch: https://github.com/theStack/bitcoin/tree/nuke_boost_process Currently the unit tests (system_tests/run_command) and functional tests (rpc_signer.py, wallet_signer.py) pass on both Linux and OpenBSD,...
> > FWIW, I started working on replacing boost::process with cpp-subprocess on the following branch: > > Does cpp-subprocess ok work on OpenBSD? Yes, at least the corresponding unit tests...
Force-pushed with suggestions from @furszy (thanks for reviewing!) and also rebased on master.
Rebased on master. The suggestion in https://github.com/bitcoin/bitcoin/pull/26129#discussion_r1032939050 is a good improvement idea, but as this PR is only focused on the `FundTransaction` result output, I decided to use the same...