Sebastian Falbesoner
Sebastian Falbesoner
Still trying to fully grasp the `IsMine` inlining commit 89503710386f52d9162f67fcd707eceffa954faa, meanwhile a few comments: * The PR description is outdated, as it still mentions adding `BerkeleyRODatabase` which was already merged...
> I guess in general it's less nice to add options to `-cli` args compared to rpcs: The alternative is that we could allow some construction like `-connect=1.2.3.4:8333|v1transport` (and similar...
Concept ACK Will review in a bit. As a follow-up idea, maybe we could put the AssumeUTXO chain and snapshot creation in a shared module, in order to deduplicate code...
Thanks for the reviews! I've tackled the [missing header include](https://github.com/bitcoin/bitcoin/pull/28455#discussion_r1434172881) and the two more instances where the refactoring can be done ([script_standard_Solver_failure](https://github.com/bitcoin/bitcoin/blob/7524fcff8625f0197be6cf84df285c39fcd5d6b6/src/test/script_standard_tests.cpp#L141) and [script_standard_ExtractDestination](https://github.com/bitcoin/bitcoin/blob/7524fcff8625f0197be6cf84df285c39fcd5d6b6/src/test/script_standard_tests.cpp#L197)). Can be easily re-reviewed via `$...
Concept ACK
Changing the `IsUnspendable` logic in general seems very brittle, as it obviously leads to nodes with diverging UTXO sets. Even if _all_ nodes would run this patch, they'd start to...
@ajtowns: Neat idea with the additional MuHash! I agree this should work, but obviously at the cost of increased complexity (as there is much more to change than only the...
Fun challenge for everyone: can you link to a specific bare multisig UTXO that has been created within the past year (let's say, since block 769785) where the prunable detection...
> > and are thus provably unspendable about 50% of the time as the data doesn't match a valid secp point. > > Sorry for not understanding this, but why...