Sebastian Falbesoner
Sebastian Falbesoner
Rebased on master (after the merge of #24748 :tada: ), and tackled https://github.com/bitcoin/bitcoin/pull/29279#discussion_r1469196012. Note that I tried enabling v2 transport for this test, but it seems that it is non-trivial...
Thanks for the reviews! In the course of rebasing the PR, I've restructured it a bit to tackle all suggestions. A new method `test_desirable_service_flags` is now introduced, which exercises the...
Force-pushed with rebase on master and tackled comment https://github.com/bitcoin/bitcoin/pull/29279#discussion_r1515598531. I reworked the `test_desirable_service_flags` method in the last commit by introducing a new `desirable_service_flags` parameter that has to be passed. Also,...
I agree that this is a "nice to have" rather than something terribly important or urgent. It's more like following best practices when providing C libraries. As for adding a...
> Could draft for now, dependant on the outcome of #29189? Agree, done.
> Why is this needed? A progress log for something that takes less than a second does not sound useful I agree that logging the detailed progress in % is...
Concept ACK
What would be the preferred way to determine the current build system settings? Is looking into the generated `test/config.ini` reliable enough? Or is parsing `src/config/bitcoin-config.h` better? (Non-trivial though, some `#defines`...