Sebastian Falbesoner
Sebastian Falbesoner
Concept ACK Nice idea. I think it makes sense to do the rollback (and roll forward after dump creation) directly in the RPC call, rather than relying on potentially fragile...
Concept ACK
> We should also simply return 0 to indicate that this transaction is not well-formed/not eligible for SP. And again, even if there are other error cases, I don't see...
According to the comments documentation of `detectSubTreeRows`, this function only works for leaf positions, so if I understand this correctly, for `numLeaves: 300`, the `position` _has_ to be in the...
One drawback of this change is that a user doesn't see download progress per file any more (relevant if e.g. servers are slow or the connection is bad for any...
Thanks for the review @rkrux! Addressed your comment https://github.com/bitcoin/bitcoin/pull/30076#discussion_r1596687155; the single taproot leaf is now accessed directly rather than by name, so there is no magic string involved anymore. Note...
Rebased on master, after the merge of #30162. Adding a functional test for tagged wallets to the new `feature_framework_miniwallet.py` (see commit e4b0dabb2115dc74e9c5794ddca3822cd8301c72) revealed another bug w.r.t. the internal key derivation....
Concept ACK Can you squash the two commits? (Currently compiling d06227fd6b87b5a427441a212c04a0ba64edc142 fails).
@AngusP: Thanks for reviewing! Seems like the tests have a code path with negative amount to `amount_split` which triggers the newly introduced exception and makes the test fail (on master,...