Sebastian Falbesoner
Sebastian Falbesoner
Thanks for the reviews! Tackled https://github.com/bitcoin/bitcoin/pull/30718#discussion_r1779726643 and also had to rebase on master (as otherwise the CI would complain, probably because the PR didn't have the switch to CMake included...
Opened a PR for BIP-373 which aims to improve the clarity of some PSBT fields containing pubkeys, which should hopefully also make reviewing this PR a bit easier: https://github.com/bitcoin/bips/pull/1705 (I...
> > determining a (w)txid for a CTransaction instance is currently rather confusing and footgunny > > I don't disbelieve you exactly as I always have to double-check what I'm...
Rebased on master (needed due to a few conflicts in functional tests after #32155 was merged).
Rebased on master.
> Bikeshed: How about `bitcoin-build-config.h` for symmetry with `bitcoin-build-info.h`? Sounds good to me, done. Both the scripted diff and the patch are now a bit larger, as also some comments/strings...
Rebased on master and added another commit fixing the outdated comment in the linter (https://github.com/bitcoin/bitcoin/pull/30937#discussion_r1773075606).
> I guess this issue can be closed. Indeed, the issue has been resolved with PR https://github.com/bitcoin-core/secp256k1/pull/1654.