Sebastian Falbesoner
Sebastian Falbesoner
Concept ACK Seems useful to create a pair of valid "same-txid-different-wtxid" transactions for testing purposes. Didn't try that yet, but I think another possibility to create these without having to...
@pablomartin4btc: > not sure if this is an issue but `tip_header.hash` (after this change) will be only used in this file later at [`test_outbound_eviction_blocks_relay_only()`](https://github.com/bitcoin/bitcoin/blob/f27898c8bfe339e2cad09d42e133a05602b1a030/test/functional/p2p_outbound_eviction.py#L235) following the same patter as above,...
Concept ACK Makes sense to me to provide at least a brief description of how the key data is structured and deserialized, since this is not intuitive at all (as...
cc @hebasto, maybe you have a better idea how to solve this; the current approach works but feels a bit hacky :)
Is it an option to be more restrictive and only allow zero-value outputs as ephemeral anchors, for not having to deal with the concept of dust at all? Or, asked...
@tdb3: > `"bitcoind.pid"` is also mentioned in `feature_filelock.py`. Could add a commit that deduplicates this. > > Created an example commit here: [tdb3@b622390](https://github.com/tdb3/bitcoin/commit/b622390b33cf3813b4f80d13377b248d6e898a4f) Thanks! I've cherry-picked your commit, but reordered...
Rebased on master, needed after https://github.com/bitcoin/bitcoin/pull/30784 got merged.
Concept ACK
Concept ACK
From what I found, the following merged upstream PRs since our initial cpp-subprocess import (see PR #28981, commit cc8b9875b104c31f0a5b5e4195a8278ec55f35f7, based on upstream https://github.com/arun11299/cpp-subprocess/commit/4025693decacaceb9420efedbf4967a04cb028e7) are not included yet in this PR...