Sebastian Falbesoner

> Thanks for starting this! Will review. Just wanted to comment that I've made a round of edits to the BIP and it is now updated with the new hashing...

> > but then we would need to pass the input pubkeys and calculate the pubkey sum twice > > (I need to actually review your implementation, but..) I don't...

I've force-pushed with a version that is now up to date with the latest state of the BIP, and updated the PR description accordingly. Labels support is also included, and...

@josibake: Thanks for the initial review, very much appreciated! > Another thought I had (need to actually re-review more carefully to confirm) is we might be able to minimize the...

Force-pushed with the following [changes](https://github.com/bitcoin-core/secp256k1/compare/c9e94c1d7327116b6529a9e9f905f4bee20973df..fa96a4a33de4729a975ecce31ad5d2fae10c514e): * parameter naming: s/outpoint_lowest/outpoint_smallest/, s/tweak_data32/private_tweak_data32/, s/tweak_data33/public_tweak_data/ (the data type for the last one was changed, see below) * API description: s/for each input/for each silent...

> > It might make sense to have a return code signalling "ignore this tx, it's not suitable for silent payments" to differentiate it from an actual error that happened....

Changed the tweak data creation interfaces to take lists of _pointers_ to seckeys/pubkeys (instead of expecting the data to come in concatenated form), as suggested in the discussion https://github.com/bitcoin-core/secp256k1/pull/1471#discussion_r1475018645. Took...

Force-pushed with interface changes in the tweak data and shared secret creation routines, following the latest suggestion in https://github.com/bitcoin-core/secp256k1/pull/1471#discussion_r1478572607 / https://github.com/bitcoin-core/secp256k1/pull/1471#discussion_r1480186475. The tweak data creation routines now return both the...

> I've rewritten [#28122](https://github.com/bitcoin/bitcoin/pull/28122) to use this module here: https://github.com/josibake/bitcoin/tree/implement-bip352-secp256k1-module. So far, so good! I'll take a fresh look here tomorrow with some feedback, and then update #28122 once I've...

@josibake: I've add the missing `_create_tweaked_pubkey` function to the API. As far as I'm aware, a user would have all the necessary routines now that are needed for a full...