secp256k1 icon indicating copy to clipboard operation
secp256k1 copied to clipboard

tests: Make CHECK enforce 1 instead of just "!= 0"

Open real-or-random opened this issue 1 year ago • 2 comments

This ensures that we don't omit the "== 1" in tests accidentally, and thus also strengthens existing tests in which it has been omitted.

We want to check "== 1" in particular for the return values of API functions, but it also makes sense in the case of internal functions.

If you really want to check "!= 0", you can still write it explicitly.


The second commit drops all the redundant "== 1"s. I tried to be careful to drop it only where it makes sense. Now, git grep "== 1" shows only instances where the 1 is supposed to be an actual integer and not a boolean. Still, this touches many lines, so I can drop this commit if you think it's too intrusive.

real-or-random avatar Jan 11 '24 15:01 real-or-random

The second commit drops redundant "-1".

You mean "== 1"?

jonasnick avatar Jan 15 '24 10:01 jonasnick

Concept ACK

theStack avatar Aug 20 '24 22:08 theStack