Sebastian Falbesoner
Sebastian Falbesoner
Thanks for the review @rkrux, I rebased on master and addressed most of your review comments.
Force-pushed again, fixing a small bug in an assertion (kudos to LLM linter for detecting this 👌 ) ```ranged-diff -+ assert "aggregate_pubkey" in in_pubnonce ++ assert "aggregate_pubkey" in in_partialsig +...
> i'll review/test your PR when ready. > > i think 1 ,3 and 4 could/should be optional as it also can be handled by the process reading the pipe...
@tdb3 @romanz: Thanks for your reviews, much appreciated! Note that the first two commits which introduce the utxo-to-sqlite.py tool (+test) are part of the base PR #27432, so further comments...
> Can we make the exists/is_fifo/open atomic somehow? Seems liable to have a race here someday... > eg [luke-jr@56ee485](https://github.com/luke-jr/bitcoin/commit/56ee485533820d8c7f0e4e27acd712aa8b411286) @luke-jr: Thanks, applied this to https://github.com/bitcoin/bitcoin/pull/31560/commits/61cef65ed1bf43d7d48ed8257441e697d6c14171. Note that I had to...
Rebased on master (now that #27432 has been merged 🎉).
Rebased on master (due to conflict with #29307, commit a69c4098b273b6db5d2212ba91cfc713c1634c5d). @yancyribbens: Sorry, I must have missed your comments back then. > Interesting - I read the link above "name pipe"...
Rebased on master (due to conflict with recently merged #32983, commit b63428ac9ce2c903670409b3e47b9f6730917ae8).
Concept ACK Nit for the future: putting the move-only changes on the existing code (i.e. introduction of the `validate_snapshot_import` and `complete_background_validation` methods) into an own refactoring commit would make reviewing...
Concept ACK on clearing out the ctx/iv members I'm wondering if a minimum-diff fix which simply replaces the `memset` calls in the dtors with `memory_cleanse` would be largely sufficient here?...