Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Relocate the per user Audience Settings out of analytics module settings so it can be accessed when the module is disconnected

IB :white_check_mark:

Relocate the per user Audience Settings out of analytics module settings so it can be accessed when the module is disconnected

Hey @aaemnnosttv, I've created https://github.com/google/site-kit-wp/issues/9325 an an initial entry point for following up on this. We'll probably want to create more issues to backport existing user settings, but we can...

Don't render the Key Metrics Selection Panel into the DOM until the feature has been set up

Thanks for the spot and the fix @ankitrox!

Don't render the Key Metrics Selection Panel into the DOM until the feature has been set up

Thanks @ankitrox, that's merged. Back to you for another pass, @mohitwp.

Add the datastore API for determining audience type (default, SK-created or user-created)

Thanks @jimmymadon, sounds sensible. Your suggestion on the design doc SGTM too.

Add the datastore API for determining audience type (default, SK-created or user-created)

@jimmymadon I'm moving this to the Backlog to help clarify which issues need to be finalised in the design doc.

Add the datastore API for determining audience type (default, SK-created or user-created)

As we've now finalised the definition for the audience configuration, along with the criteria for differentiating the audience types, I've completed the AC and moved this to IB.

Add the datastore API for determining audience type (default, SK-created or user-created)

Thanks for the IB @nfmohit. This LGTM. It's worth noting that due to the [audience caching](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.cwpr2gxebffj) aspect of the feature, which is currently being finalised in the design doc, we're...

Add the datastore API for determining audience type (default, SK-created or user-created)

Hmm having iterated further on the audience caching section of the design doc, it's worth noting that the definitions for the `isDefaultAudience()`, `isSiteKitAudience()` and `isUserAudience()` in the doc have been...

Add the datastore API for determining audience type (default, SK-created or user-created)

@nfmohit, sorry to do a bit of a 180 here but as the audience caching infrastructure issue #8486 has now been defined with ACs, and considering where we're at with...