Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Thanks @nfmohit, the IB LGTM! :white_check_mark: Please can you add an estimate, and move it to the EB. Cheers!

Hi @kelvinballoo, thanks for asking. > - @techanvil I want to ask more about the last point : > `Additionally, the selectors should return undefined when run prior to the...

Having confirmed the `AudienceSegmentationSetupSuccessSubtleNotification` VRTs all pass in the [test run for this issue's PR](https://github.com/google/site-kit-wp/actions/runs/11367605257/job/31622097898?pr=9516), and merged the PR, I'm moving this to Approval. ![Image](https://github.com/user-attachments/assets/49ce7a2b-54e4-42ff-86b9-fd7574b35599)

Hi @aaemnnosttv, please can you review the AC for this one? This fleshes out requirements that we didn't get into the detail of in the design doc that would be...

Hi @aaemnnosttv, thanks for the feedback. > > The "new visitors" audience should exist and have a non-zero user count over the past 90 days. > > Should this be...

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

Hi @benbowler, nice work so far on the IB. A couple of points: Providing a `Header` property does make sense at first glance, particularly as we've recently introduced the `Footer`...

Thanks @benbowler! I've made a small tweak - you meant `WEEK_IN_SECONDS * 4` as the expiry time is 28 days. Something else has occurred to me though, which is worth...

Great, thanks @benbowler! IB LGTM :white_check_mark:

Hi @benbowler, just chipping in to say I think it would be preferable to take the approach of passing in options or a set of selector names and args to...