site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard
verified publisher icon google

Fix VRT reference image for AudienceSegmentationSetupSuccessSubtleNotification at the small viewport width.

Open techanvil opened this issue 1 year ago • 2 comments

Feature Description

Refactoring the notification via https://github.com/google/site-kit-wp/issues/9281 changed the CTA layout at narrow viewports, but the small VRT reference image wasn't updated at the time and the scenario is currently failing. We need to update the corresponding VRT reference image to fix it.

See the initial failing run at https://github.com/google/site-kit-wp/actions/runs/11293262529/job/31410996970#step:5:6532

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The VRT scenario for the AudienceSegmentationSetupSuccessSubtleNotification component should pass at all viewport widths.

Implementation Brief

  • [ ] Update the small VRT reference image for the AudienceSegmentationSetupSuccessSubtleNotification component.

Test Coverage

  • As above.

QA Brief

  • No QA needed; VRTs should pass.

Changelog entry

  • N/A

techanvil avatar Oct 15 '24 15:10 techanvil

IB ✅

tofumatt avatar Oct 15 '24 19:10 tofumatt

Having confirmed the AudienceSegmentationSetupSuccessSubtleNotification VRTs all pass in the test run for this issue's PR, and merged the PR, I'm moving this to Approval.

Image

techanvil avatar Oct 16 '24 15:10 techanvil