Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Hey @kelvinballoo! Thanks for flagging these defects. They are both valid concerns, but are outside the scope of this issue. Please can you raise issues for them?

Hey @benbowler, actually the AC for this needs a revision. It's not the case that we want the WP Consent API plugin to be installed in direct response to the...

Hi @benbowler, thanks for updating the AC. - It looks like the point about the `como_enable` event is now redundant and can be removed. - Also, it would be good...

@benbowler thanks for the update. Please note I made a small change to tweak the proposed error text and fix a couple of typos. That said - while I like...

Great, thanks @benbowler! AC :white_check_mark:

Incidentally I don't think we'll need an explicit Retry button as the Install/Activate buttons will allow retrying...

Hey @benbowler, thanks for looking into this. The trickier case that you'll need to update the IB for is when the GTM container points to a Google tag, which in...

Hi @benbowler, and apologies, while reviewing the updated IB here I realised that I'd missed a point from the AC, which I've now added. The IB will need an update...

Thanks @benbowler! It's looking good. A few last points: - On reflection I think `ads-measurement-status` would be preferable for a REST endpoint name as it's more indicative of a "resource",...

Hey @zutigrm! Thanks for the update, and sorry that we missed the lack of support for the `tag_id` parameter during definition. I think your first suggestion makes the most sense...