Tom Rees-Herdman comments

Results 525 comments of


                                            Tom Rees-Herdman

Implement the full-tile error states for the Audience Tile

Hi @hussain-t, just letting you know I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, will probably affect the AC...

Implement the full-tile error states for the Audience Tile

Hi again @hussain-t! As the audience caching aspect of the design doc has been sufficiently finalised, I've moved this back to AC.

Implement the full-tile error states for the Audience Tile

Thanks @hussain-t, nice work here so far on the IB. A couple of points: > * [ ] Retrieve all the following report errors using the `getErrorForSelector` by passing the...

Implement the full-tile error states for the Audience Tile

Thanks @hussain-t! Nice work, that LGTM. IB :white_check_mark:

Implement the full-tile error states for the Audience Tile

Hey @hussain-t, while working on the IB for #8190 I've noticed that one detail of the AC has been missed in the IB here. > - In the case where...

Implement the full-tile error states for the Audience Tile

Thanks @hussain-t! IB :white_check_mark: once again :)

Implement the full-tile error states for the Audience Tile

Nice work on the QAB here @ankitrox. One suggestion - it's possible the audience IDs will change in the future if they are archived and recreated. So, I will suggest...

Implement the full-tile error states for the Audience Tile

Hey @ankitrox, good work on the PR which I have merged. Please can you take a look at my comment above re. the QAB.

Implement the full-tile error states for the Audience Tile

Hi @kelvinballoo, thanks for raising these issues. > **ITEM 1:** ⚠️ For the 2nd scenario where the full width error appears, the Info notice doesn't appear as expected. However, if...

Implement the full-tile error states for the Audience Tile

> **ITEM 1** ⚠️ For item 1, I re-tested this and noticed that you have put the tiles in loading state. Agreed on that. Just confirming as well that, it's...