Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Hi @benbowler, this would be a good solution if we did want to retain the state when the user reverts to the same property later. However, this is not actually...

Hey @benbowler, thanks for drafting this IB. A few points to consider: > * [ ] Check the user has setup permissions before continuing `current_user_can( Permissions::SETUP );`. Hmm... This might...

Update to the above: > Maybe, instead of reusing the `get_authenticated_users()` logic, we can invoke `get_users()` to only return users who have the `googlesitekit_audience_settings` user option set. This should suffice...

@aaemnnosttv and I had a good chat about this but haven't yet determined the way to go here - he's going to take another look async and leave his thoughts...

Thanks for your feedback, @aaemnnosttv! > > - When the connected Analytics property is changed, either when selecting a new property via the Analytics settings, when disconnecting Analytics, or resetting...

Thanks @aaemnnosttv, good points there. 1. I've updated the AC/IB to remove the requirement to clear the hidden state of the widget area. 2. I have amended the IB to...

Update: I've also added the hidden state for the No Audiences Banner and the `didSetAudiences` flag that we are introducing via https://github.com/google/site-kit-wp/issues/8577 to the list of settings to clear on...

Thanks @kelvinballoo, I've taken a look at your feedback. > **ITEM 1:** ⚠️ I have used 3 users to the site. When testiing for the googlesitekitpersistent_dismissed_items, I dismissed all the...

Note, I've moved this to the backlog pending the addition of the [full width error state](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.xfl89g3zosvd) as a GitHub issue, which this issue may depend on.

The full width error state is now defined and added as a dependency for this issue, which is ready for AC.