Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Thanks @ankitrox. I've had another read of the IB and a couple of things occur to me. As it stands: - There will be a small change to the current...

Thanks @ankitrox, that's looking good. My only minor quibble is regarding the `initialVisibility` name, as this doesn't in isolation reflect the component's visibility. I'd suggest we either rename it to...

Thanks @ankitrox, that's great. The IB LGTM! :white_check_mark:

Back to you for another pass, @kelvinballoo. Please note that with regard to Item 2, the dropdown size is derived from content. As per this https://github.com/google/site-kit-wp/pull/9073#discussion_r1691287607 (which you may have...

Moving this back to execution to fix the RRM `SetupMain` story that developed an error as a result of its first PR.

Note: I tested this out, with intermittent results. In my initial testing the bug only occurred when the first tile was in the zero data state. However, I tried it...

Hi @ankitrox, as you've pointed out this issue can also occur with user-created audiences that we don't have the special-case handling for. So we do need a general fix for...

IB :white_check_mark:

Thanks @kelvinballoo and @nfmohit. Showing the CTA below the widget area as per the mockup above looks fine to me. We do have a design in [Figma](https://www.figma.com/design/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?node-id=1936-23403&m=dev) showing the CTA...

Thanks @sigal-teller. Just noting that, as per the [Figma design](https://www.figma.com/design/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?node-id=1956-17186&m=dev), we'll show the CTA below the widget area up to a breakpoint of 782px, from 783px we'll show it above...