Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @ankitrox! The IB for #8923 has now been approved, so this should be good for an update.

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @ankitrox, that's great; note that I also made a couple of minor tweaks to the IB. Once again, this IB LGTM. :white_check_mark:

Implement the “partial data” badges

Thanks @kuasha420. I've made a minor tweak for the type of the `tooltipTitle` prop. This IB LGTM, nice one!

Implement the “partial data” badges

@nfmohit, thanks, good spot. The tooltip should indeed be triggered when the icon is hovered - this will be consistent with elsewhere, for example the info tooltip for the [Audience...

Add the Settings Section setup CTA variant including happy path setup behavior

Hi @nfmohit, personally I would prefer to keep the AC as they stand, as the IB for #8874 has already been approved and it would need a rewrite; the common...

Add the Settings Section setup CTA variant including happy path setup behavior

Thanks @hussain-t! As mentioned on Slack, I've created #9065.

Add the Settings Section setup CTA variant including happy path setup behavior

Back to you for another pass, @kelvinballoo.

Remove Ads bullet point from Consent Mode modal when Ads is not connected.

Hi @hussain-t, thanks for raising this. The copy should indeed be updated as you've pointed out. I've also realised the AC had become a bit out of date with regard...

Handle changing the connected Analytics property

I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, will probably affect the AC for this one

Handle changing the connected Analytics property

The audience caching aspect of the design doc has been sufficiently finalised, and I've moved this back to AC.