Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Extract and rewrite Consent Mode JS snippet.

Just peeking in here. @benbowler, please don't forget this point of the AC: > - Rewrite to use modern language features. E.g. we can drop the use of `var`, and...

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Note that I've moved this to the Backlog as we have an open [discussion](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABEVx_moU) on the "collecting data" terminology in the design doc.

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

The aforementioned discussion has been resolved, and this is ready for AC.

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Hi @ankitrox, thanks for drafting this IB. You raise an interesting concern as to how this issue relates to #8726. On balance, I think it would in fact be preferable...

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @ankitrox! The IB is most of the way there. A couple of smallish points: - The `audienceResourceName` property is the `name` of an audience and looks something like `properties/433726123/audiences/8044127456`....

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @ankitrox! One more thing - > Inside the function call the `getAvailableAudiences` selector and map the `audienceResourceName` to `audienceSlug` to form a new list to lookup in the next...

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thank for the update, @ankitrox! The IB LGTM. :white_check_mark:

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Hi @ankitrox, in light of the fact we're reverting the change for this issue's dependency https://github.com/google/site-kit-wp/issues/8726, please can you review the IB for this issue and adjust it as necessary?

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @ankitrox. The IB was mostly looking good - I've given it a bit of a tweak, fixing a couple of plural names and some minor grammatical errors, and making...

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Hey @ankitrox, I've sent this back to you in IB for an update to reuse the selectors we are defining in https://github.com/google/site-kit-wp/issues/8923.