Thomas Coratger
Thomas Coratger
> @abdelhamidbakhta I can take this :) @bajpai244 assigned
@lana-shanghai @dhruvkelawala This is already done here no? https://github.com/keep-starknet-strange/ziggy-starkdust/blob/main/src/parser/deserialize_utils.zig
> would like this one @oxlime Assigned
Require further investigations to know if this is something efficient when dealing with temporary segments which could lead to negative indexes.
> hmm technically chainid can be u64, so this sounds reasonable, although probably a bad choice to pick a chainid where this is possible so maybe not worth it, but...
> > > hmm technically chainid can be u64, so this sounds reasonable, although probably a bad choice to pick a chainid where this is possible so maybe not worth...
> I don't think the first optimization is right. The early return adds an additional branch, so it may make the average case slower, and we usually don't care about...
@entropidelic Let me know if there is something to do here
> when you say it isn't complete, what do you mean? This is the consensus receipt type, and doesn't need anything else to be complete I think that we miss...
> please remove all semicolons, these should not be allowed with our policy to use `cargo +nightly fmt`. `make pr` may get rid of them, mind trying that? done