ziggy-starkdust icon indicating copy to clipboard operation
ziggy-starkdust copied to clipboard

tests: add more unit tests for `getAllocatedMemoryUnits` involving Cairo Program

Open tcoratger opened this issue 1 year ago • 3 comments

Issue Description

After ensuring that the Program structure is properly handled by our Cairo runner, we will have to enhance the test coverage for the getAllocatedMemoryUnits method within the BuiltinRunner union(enum).

To achieve this, we need to add more unit tests covering various scenarios and edge cases. These tests will validate the behavior of the getAllocatedMemoryUnits method under different conditions, ensuring robustness and reliability.

The relevant code section for the getAllocatedMemoryUnits method can be found here:

https://github.com/lambdaclass/cairo-vm/blob/4ea224a1068b43aaa3899d24e834475106e8a78f/vm/src/vm/runners/builtin_runner/mod.rs#L793-L971

Action Items

  • Add unit tests for getAllocatedMemoryUnits method in BuiltinRunner union(enum).
  • Ensure comprehensive coverage of different scenarios and edge cases.
  • Validate the behavior of the method under varying conditions.

tcoratger avatar Feb 20 '24 15:02 tcoratger

would like this one

oxlime avatar Feb 22 '24 08:02 oxlime

would like this one

@oxlime Assigned

tcoratger avatar Feb 22 '24 10:02 tcoratger

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Mar 24 '24 00:03 github-actions[bot]