Thomas Coratger

Results 52 comments of Thomas Coratger

> > yeah, can you elaborate the clip check issue > > `clippy` check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step...

> > > > yeah, can you elaborate the clip check issue > > > > > > > > > `clippy` check sorry, just reworded it. As mentioned by...

> #3233 is more about being able to set block gas limit through the `ChainSpec` instance, not just having a default method on it. > > e.g. user runs `reth...

> @tcoratger It's still not entirely done, the main issue here is that even if I set a different gas limit in my chainspec, this will not actually affect much...

Is there a plan here to integrate `.toml` file formatting directly into the `rustfmt` library or is it out of the scope?

@ytmimi Yes that was my question if the `Cargo.toml` files were in scope. I saw the comment mentioned (https://github.com/rust-lang/rustfmt/issues/4091#issuecomment-612333467) but since it is 3 years old I was wondering if...

Duplicate of https://github.com/arkworks-rs/algebra/issues/645 no?

> This is behaviour that we want to hide. See, eg, #769 @Pratyush Great then if I understand well the proposed solution I imagine it will make sense to implement...

@Pratyush I thought about this PR and because the `MulAssign` or `AddAssign` traits of the Rust library use the suffix `Assign`, we will necessarily have `mul_assign` or `add_assign` which will...

@mmaker Agreed, I found it confusing at the beginning like in Montgomery backend for exemple we have: - `add_assign` - `sub_assign` - `double_in_place` - `neg_in_place` The `std` library always uses...