Thomas Coratger comments

Results 52 comments of


                                            Thomas Coratger

add `use_self` clippy lint

> lgtm, > > this could perhaps result in a few conflicts, but those can be easily resolved > > I'm keeping this open, because we're about to merge a...

add `use_self` clippy lint

> @tcoratger as promised a ton of conflicts hehe > > maybe it's easier to start over, does cargo --fix apply these automatically? No problem, done :)

replace `Box::new` by `into()` when possible

> I think in this case the `.into()` removes readability of the code so i'm not so inclined to merge this. Feel free to close if you find it not...

Update some crate versions

> please resolve the conflicts @edg-l done

Update some crate versions

> @tcoratger please, fix conflicts :) done

Update some crate versions

@igaray Since https://github.com/lambdaclass/cairo_native/pull/566 is merged, we could merge this one, wdyt?

Update some crate versions

@pefontana I know that this is a stupid small PR but I would not close it for two reasons: - It contains the update of all the crates. Even if...

add `matches_type` for array in arg mapper and tests

@igaray is there anything missing here?

add `matches_type` for array in arg mapper and tests

@azteca1998 Just fixed the conflicts, let me know if we can merge

add test for non vacant `MetadataStorage` `insert`

@igaray Is there anything missing here?