Thomas Coratger
Thomas Coratger
@igaray Is there anything missing here?
@azteca1998 Just fixed the conflicts, let me know if we can merge
I think, at least for `test_drop_lock `, this is because of the following line: https://github.com/paradigmxyz/reth/blob/b1d6e27e3f147678243423a35593c8357a6dabaa/crates/storage/db/src/lockfile.rs#L37-L38 as we don't use ```rust Ok(Self(Arc::new(StorageLockInner::new(file_path)?))) ``` I imagine because of the comment (ef tests...
Looks good to me, just two remarks: - For the codegen file, this should be handle directly at source, can you confirm @xJonathanLEI ? - Can you rebase on main?
lgtm @xJonathanLEI what about codegen file?
@thetheveloper can you rebase to trigger the ci again? I think this should be good now
> @tcoratger @xJonathanLEI anything else needed? thanks! For me this is ok to merge but as the PR is quite big and important I would appreciate another review from @xJonathanLEI...
> We would like to be assigned to this issue > > cc @tcoratger @xJonathanLEI Assigned
> We would like to be assigned to this issue > > cc @tcoratger @xJonathanLEI Assigned
> TBH I don't think the `inner` part makes any difference. I could be wrong but I think a single field struct should be exactly equivalent to a newtype struct...