Thomas Coratger

Results 69 issues of Thomas Coratger

Should solve #3233.

C-enhancement
A-consensus

## Description This pull request introduces a standardized naming convention for methods in the `BigInteger` module, specifically targeting functions where the `self` mutable value is modified in-place. The convention adds...

## Description Currently, there are two separate implementations for iterating over a slice of `u64` in big-endian and little-endian order, namely `BitIteratorBE` and `BitIteratorLE`. These implementations have similar functionalities but...

At the moment, the `add_assign` operation between two points in projective coordinates in the short weierstrass model implements the generic method (without any assumption over `Z1` and `Z2`) here: https://github.com/arkworks-rs/algebra/blob/3a6156785e12eeb9083a7a402ac037de01f6c069/ec/src/models/short_weierstrass/group.rs#L451-L537...

In the whole codebase, there is a standard which is to include the suffix `in_place` on operations which modify the value passed as a mutable parameter. For example here: https://github.com/arkworks-rs/algebra/blob/cc2ad8c368c323ee9d9aacaabf8e353de95682e6/ec/src/models/bn/g2.rs#L53-L77...

### Feature Request Implement the `Deref` trait for the `BigInt` structure to allow users to conveniently access the underlying array. ## Context The `Deref` trait allows types to be treated...

# Simplify `get_offset_value_reference` and add unit tests ## Description - The logical test on `base_addr` and `offset` to know if we should return null is implicitly already provided by the...

tests
coverage

# Complete test suite of `BuiltinRunner` `get_memory_segment_addresses` ## Description A few test assertions are added to the test suite related to `get_memory_segment_addresses` for `BuiltinRunner` implementation in order to complete the...

tests

# Add test coverage for `get_constant_from_var_name` ## Description Add a series of unit tests for `get_constant_from_var_name` hint util method. ## Checklist - [ ] Linked to Github Issue - [X]...

tests

# Add unit test for `apply_ap_tracking_correction` with invalid offset ## Description This pull request adds a new unit test for the `apply_ap_tracking_correction` function in order to cover the scenario where...