Michaël Zasso
Michaël Zasso
It looks like the commit message was edited when it landed on v22.x: https://github.com/nodejs/node/commit/8743c4d65a51df80c5ac4d1dc873bfe572f2bb0c I'm marking this as backported so it doesn't show up in `branch-diff`'s output.
I relaunched the failed `test-asan` job
Unfortunately, we were not able to come up with a solution that doesn't require us to write the bindings for each function manually.
Hello! Thank you for the pull request (and sorry it took a bit long to answer you). It seems indeed useful to have this optimization available, but we'd like to...
Has anyone tried to benchmark the current implementation of `util.promisify` vs. one written with the functions provided by V8 extras?
@benjamingr you can try with this branch: https://github.com/targos/node/commits/expose-v8-extras I checked with a very simplistic benchmark and the V8 extras seem to bring a non-negligible improvement: ```js 'use strict'; function asyncF(cb)...
@benjamingr not sure I'm following. My branch is on V8 6.0, not 6.2.
https://github.com/nodejs/citgm/actions/runs/9016535461
It refuses to run tests on unsupported versions of Node.js, which won't help to find regressions. ``` error: | AssertionError [ERR_ASSERTION]: Current node version is not supported for development, expected...