citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: add React

Open targos opened this issue 1 year ago • 4 comments

Closes: https://github.com/nodejs/citgm/issues/1038

I looked at https://github.com/facebook/react/blob/main/.circleci/config.yml to prepare a first draft.

targos avatar May 09 '24 11:05 targos

https://github.com/nodejs/citgm/actions/runs/9016535461

targos avatar May 09 '24 11:05 targos

It refuses to run tests on unsupported versions of Node.js, which won't help to find regressions.

error:                     | AssertionError [ERR_ASSERTION]: Current node version is not supported for development, expected "22.1.0" to satisfy "16.x || 18.x || 20.x || 21.x".                                                                        
error:                     | at Object.<anonymous> (/tmp/6f82fd48-e79e-4aab-a0bf-d5226b5f47d0/react/node_modules/fbjs-scripts/node/check-dev-engines.js:46:3)   

targos avatar May 09 '24 11:05 targos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.74%. Comparing base (12e6902) to head (6ed37c2). Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   96.35%   92.74%   -3.61%     
==========================================
  Files          29       29              
  Lines        2192     2192              
==========================================
- Hits         2112     2033      -79     
- Misses         80      159      +79     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 09 '24 11:05 codecov-commenter

One test fails on Node.js 18 and 20. Node.js 21 fails because global.navigator is not writable.

targos avatar May 09 '24 11:05 targos

https://github.com/nodejs/citgm/actions/runs/12560851713

targos avatar Dec 31 '24 14:12 targos