node icon indicating copy to clipboard operation
node copied to clipboard

path: add `matchGlob` method

Open redyetidev opened this issue 9 months ago • 5 comments

Fixes #52779

The path.matchGlob(path, pattern) checks whether a glob (pattern) matches the input path (path).

redyetidev avatar May 07 '24 20:05 redyetidev

"Label PRs / label" appears to have crashed, so I manually labeled the PR.

@nodejs/actions https://github.com/nodejs/node/actions/runs/8992208708/job/24701514516

GitHub Actions has encountered an internal error when running your job.

redyetidev avatar May 07 '24 21:05 redyetidev

The https://github.com/nodejs/node/labels/notable-change label has been added by @MoLow.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

github-actions[bot] avatar May 08 '24 06:05 github-actions[bot]

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/9017575572

github-actions[bot] avatar May 09 '24 12:05 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59054/

nodejs-github-bot avatar May 09 '24 13:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59063/

nodejs-github-bot avatar May 09 '24 18:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59128/

nodejs-github-bot avatar May 11 '24 23:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59156/

nodejs-github-bot avatar May 12 '24 08:05 nodejs-github-bot

Hey, is this mergeable? Or are there still objections?

redyetidev avatar Jun 22 '24 21:06 redyetidev

CI: https://ci.nodejs.org/job/node-test-pull-request/59930/

nodejs-github-bot avatar Jun 22 '24 21:06 nodejs-github-bot

CI passed :tada: (Except for (AFAICT) unrelated failure parallel.test-crypto-worker-thread)

redyetidev avatar Jun 22 '24 23:06 redyetidev

commit-queue-squash is okay, right?

If landed, the commits should be squashed - just making sure it's okay for me to add the label.

redyetidev avatar Jun 22 '24 23:06 redyetidev

CI: https://ci.nodejs.org/job/node-test-pull-request/59935/

nodejs-github-bot avatar Jun 23 '24 04:06 nodejs-github-bot

commit-queue-squash is okay, right?

If landed, the commits should be squashed - just making sure it's okay for me to add the label.

Yeah, this is the label needed. Since it only tells the commit queue how to handle, I see no reason it shouldn't be ok

atlowChemi avatar Jun 23 '24 04:06 atlowChemi

Landed in 92a25abca9dd23a723008d88b1ccb63ff40ec9b7

nodejs-github-bot avatar Jun 23 '24 06:06 nodejs-github-bot

It looks like the commit message was edited when it landed on v22.x: https://github.com/nodejs/node/commit/8743c4d65a51df80c5ac4d1dc873bfe572f2bb0c

I'm marking this as backported so it doesn't show up in branch-diff's output.

targos avatar Jul 28 '24 06:07 targos