node
node copied to clipboard
path: add `matchGlob` method
Fixes #52779
The path.matchGlob(path, pattern)
checks whether a glob (pattern
) matches the input path (path
).
"Label PRs / label" appears to have crashed, so I manually labeled the PR.
@nodejs/actions https://github.com/nodejs/node/actions/runs/8992208708/job/24701514516
GitHub Actions has encountered an internal error when running your job.
The https://github.com/nodejs/node/labels/notable-change label has been added by @MoLow.
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9017575572
CI: https://ci.nodejs.org/job/node-test-pull-request/59054/
CI: https://ci.nodejs.org/job/node-test-pull-request/59063/
CI: https://ci.nodejs.org/job/node-test-pull-request/59128/
CI: https://ci.nodejs.org/job/node-test-pull-request/59156/
Hey, is this mergeable? Or are there still objections?
CI: https://ci.nodejs.org/job/node-test-pull-request/59930/
CI passed :tada: (Except for (AFAICT) unrelated failure parallel.test-crypto-worker-thread
)
commit-queue-squash
is okay, right?
If landed, the commits should be squashed - just making sure it's okay for me to add the label.
CI: https://ci.nodejs.org/job/node-test-pull-request/59935/
commit-queue-squash
is okay, right?If landed, the commits should be squashed - just making sure it's okay for me to add the label.
Yeah, this is the label needed. Since it only tells the commit queue how to handle, I see no reason it shouldn't be ok
Landed in 92a25abca9dd23a723008d88b1ccb63ff40ec9b7
It looks like the commit message was edited when it landed on v22.x: https://github.com/nodejs/node/commit/8743c4d65a51df80c5ac4d1dc873bfe572f2bb0c
I'm marking this as backported so it doesn't show up in branch-diff
's output.