src: remove ArrayBufferAllocator::Reallocate override

[syg]

It's being deprecated and removed in V8.

See https://issues.chromium.org/u/1/issues/331326406.

[syg]

cc @addaleax @tniessen who were the reviewers for the related PR https://github.com/nodejs/node/pull/52292

[github-actions[bot]]

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/9016827306

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59122/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59140/

[syg]

@benjamingr I see that I got the commit message capitalization wrong. Should I force-push with the correct capitalization? I imagine that'll need a new CI run.

[benjamingr]

Hey sorry I missed that:

Should I force-push with the correct capitalization? I imagine that'll need a new CI run.

Sure, let's do that and re-run CI, it's not a rush but if it were we can land without re-running CI

[syg]

Lowercased commit message and rebased.

[syg]

Ping on merging.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59642/

[syg]

I see a failure with [ FAILED ] InspectorSocketTest.HostIPv6NonRoutable. Dead code removal shouldn't cause any failures. Before I investigate further, is that a known flake to folks who regularly work with the project?

[isheludko]

Can we please move forward with this? This issue is blocking enabling of usages of deprecated V8 Apis in V8's Node-CI bots.

[syg]

@joyeecheung Please help us land this. :)

[targos]

I relaunched the failed test-asan job

[nodejs-github-bot]

Landed in 1aea950eb266e6f1ef7731f3675b1639aa9d0756