Michaël Zasso
Michaël Zasso
CI is green.
This needs a new approval after my force-push
``` 08:06:57 ok 2 v8-updates/test-linux-perf-logger 08:06:57 --- 08:06:57 duration_ms: 709.58200 08:06:57 ... 08:06:57 08:06:57 All tests passed. ```
This PR adds a feature so it should be labeled https://github.com/nodejs/node/labels/semver-minor (this is not supposed to be done by releasers).
``` C:\workspace\node-compile-windows\node\test\cctest\test_node_task_runner.cc:41 Expected equality of these values: node::task_runner::EscapeShell(input) Which is: "\"\"\"$1\"\"\"" expected Which is: "\"\"$1\"\"" ```
It's probably related to V8, but I'm not sure waiting would have changed anything? We released v22.0.0 with the version of V8 that's in current Chrome.
Seems specific to Linux or x64 as I cannot reproduce on ARM64 macOS.
We also don't know which version of V8 introduced the bug (assuming it's in V8).
So, it's specific to x64. I can reproduce with `node-v22.0.0-darwin-x64` on Rosetta.
I'm going to compile a debug build on one of the Hetzner machines to get a meaningful stack trace.