Michaël Zasso
Michaël Zasso
It was asked by the V8 team that we didn't expose it: https://github.com/nodejs/node/pull/37570#issuecomment-793436245 I don't object to add it if the situation is better now.
As @richardlau suggested: add `lts-watch-*` labels.
Commits are not always squashed. What's important if you want to keep 3 separate commits is that they each have a valid commit message, the project builds, and tests pass...
Somehow it broke test-asan.
Trying to remove as many `-W` flags as possible from the V8 build config. I'll re-add them if necessary.
Does it work well with the `parallel.status` file?
Can you still run only "http" tests with `./tools/test.py http` ?
@nodejs/http @nodejs/testing
Stopping for now. Locally, current error is: ``` ..\..\out\Release\\obj\global_intermediate\icudt75l_dat.obj: unknown machine: 0 C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(1599,5): error MSB6006: Arrêt de "llvm-lib.exe" avec le code 1. [D:\Git\nodejs\node\tools\icu\icudata.vcxproj] ``` Which is https://github.com/nodejs/node/issues/34201...
Rebased on https://github.com/nodejs/node/pull/52873 so I can use what it does. I added a better version of the ICU hack based on the suggestion from https://github.com/nodejs/node/issues/34201#issuecomment-660868415. I say we wait for...