Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

remove the warning about performance hit in --experimental-detect-module

I don't think the ecosystem is going to start relying on automatic detection. This will break TypeScript, ESLint, etc.

tools: migrate to ESLint flat config and update ESLint to v9.2.0

@nodejs/linting

tools: migrate to ESLint flat config and update ESLint to v9.2.0

> > For now, I put the entire config in one file. I would like to split it into multiple files to make it more readable but I'm not sure...

tools: migrate to ESLint flat config and update ESLint to v9.2.0

SGTM. I'll wait a few days to see if there are other suggestions.

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Done! I went with `eslint.config_partial.mjs` so I could colocate it with `eslint.config_utils.mjs` in `tools`.

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Looks like `lib/eslint.config_partial.mjs` is picked up by `js2c.cc`. Not sure what's the best way to ignore it. /cc @joyeecheung

tools: migrate to ESLint flat config and update ESLint to v9.2.0

> @targos Can we also enable indentation rule for "Makefile" file? @anonrig Maybe, but it doesn't seem related to what I'm doing here?

tools: migrate to ESLint flat config and update ESLint to v9.2.0

This is ready for reviews.

tools: migrate to ESLint flat config and update ESLint to v9.2.0

``` 09:25:44 Running JS linter... 09:25:46 09:25:46 Oops! Something went wrong! :( 09:25:46 09:25:46 ESLint: 8.57.0 09:25:46 09:25:46 Error: EMFILE: too many open files, open '/home/iojs/build/workspace/node-test-linter/test/parallel/test-timers-immediate-unref-nested-once.js' ``` 🤔

tools: migrate to ESLint flat config and update ESLint to v9.2.0

I developed it on Windows.