Michaël Zasso
Michaël Zasso
I have no simple idea to fix it then. If we look at Chromium, I *think* they just prebuild the data files and add them to source control: https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/common/
> This feature interests me. Looking at the code, this looks like a PoC, which is completely fine for this stage, but I was just wondering what you see as...
I ported everything from the previous PR. Build works on my Windows PC.
When building locally, I noticed a lot of warnings on the OpenSSL side. Should we care about them? @nodejs/crypto Unknown escape sequence: ``` openssl\crypto\ct\ct_log.c(173,15): warning : unknown escape sequence '\...
It's what it does for now, but my intention is to refactor to add an option.
Added an option in https://github.com/nodejs/node/pull/52870/commits/58a7bf7446206c2f67730ec6119056a3b634b918
Rebased, squashed into a single commit, removed the ICU hack. Now MSVC should be the default and I think we can land this PR.
> once this lands we'll have an option to use clang, but the default will not change That's the intention. > ICU hack is completely removed so Clang will only...
> One more thing we should consider is how will changing from MSVC to clang affect other parts of the ecosystem eg. node-gyp, some packages, etc.. From, what I know,...
@StefanStojanovic Thanks, I added your patch!