Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Note that `.\vcbuild.bat lint-js` is already broken on Windows on the main branch because of this file: https://github.com/nodejs/node/blob/main/tools/node_modules/eslint/node_modules/eslint

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Proof it works after deleting the symlink: ``` PS D:\Git\nodejs\node> .\vcbuild.bat lint-js nobuild noprojgen Looking for Python Python found in C:\Users\Targos\AppData\Local\Microsoft\WindowsApps\\python.exe Python 3.12.3 Looking for NASM Jonction créée pour Release...

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Retrying node-test-linter: https://ci.nodejs.org/job/node-test-linter/54555/

tools: migrate to ESLint flat config and update ESLint to v9.2.0

It's probably https://github.com/eslint/eslint/issues/18301, only fixed in ESLint v9. I'll add the ESLint update to this PR.

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Blocked on https://github.com/nodejs/node/pull/52889

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Added the update to ESLint v9

tools: migrate to ESLint flat config and update ESLint to v9.2.0

It must be running a very old version of node !

tools: migrate to ESLint flat config and update ESLint to v9.2.0

``` 19:19:01 + node --version 19:19:01 v16.20.2 ```

tools: migrate to ESLint flat config and update ESLint to v9.2.0

We need to upgrade the host. Node.js 18+ can't run on Ubuntu 18. Opened https://github.com/nodejs/build/issues/3713

tools: migrate to ESLint flat config and update ESLint to v9.2.0

Rebased, reworded the first commit so the PR can be squashed, and separated additional fixes from the ESLint update to ease reviews. (this is still blocked on updates of the...