Michaël Zasso
Michaël Zasso
macOS 10.15 is no longer supported to build node. We require at least macOS 11.
It's specific to the clang version that ships with Xcode on 10.15
Official macOS releases are built with Xcode 13.2.1 too and we don't get this error 🤔
@aduh95 Now I know why we didn't specify a commit message in the action settings. `git node v8` already creates the commit (It's supposed to have a "Refs:" trailer).
That error was expected (I had reset the GH Actions cache). Error is caught here: https://github.com/nodejs/node-core-utils/blob/d7b00b533dd7ef455b4f4255e4e20fd1b05b6f59/lib/update-v8/updateV8Clone.js#L17-L35 Log happens here: https://github.com/nodejs/node-core-utils/blob/d7b00b533dd7ef455b4f4255e4e20fd1b05b6f59/lib/run.js#L64
Here's a run on my fork with debug logs enabled: https://github.com/targos/node/actions/runs/9050008411/job/24864881790 Relevant: ``` ##[debug]Changes to be committed: ##[debug] (use "git restore --staged ..." to unstage) ##[debug] modified: deps/v8/include/v8-version.h ##[debug] modified:...
With proper git setup: https://github.com/targos/node/actions/runs/9050110263/job/24865219130 For some reason, the action doesn't consider the new commit as a local change: ``` ##[debug]DEFAULT_BRANCH: main ##[debug]$ git status ##[debug]On branch test-v8-patch ##[debug]Your branch...
I'll try https://github.com/peter-evans/create-pull-request on my fork. It seems more maintained.
Landed in e4b187433de1
@lemire yes, here: https://ci.nodejs.org/job/node-compile-windows/55884/nodes=win-vs2022-arm64/