Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

deps: update undici to 6.6.2

Rebased.

build: implement build android workflow

- Is there any way to try and run it before merging? - Is it going to block commit queue when it fails?

build: implement build android workflow

> This is an experimental feat., it shouldn't block commit queue even if fails. I know it shouldn't, but I'm afraid it will (it runs on `pull_request` event).

build: implement build android workflow

We can use `continue-on-error`. It will make the run always green. I'm still sceptical about having feedback on all pull requests for a very experimental target. A new actions run...

`Object.getOwnPropertyDescriptor(global, 'performance').writable` is no longer true in v18.19.0

Is it supposed to be `true` ?

String that looks like a source map comment gets used as a source map comment, but only in ESM

V8's `GetSourceMappingURL()` API is also available on modules.

deps: update zlib to 1.3.0.1-motley-646b7f5

I only see changes in `.patch` files. Does it mean we do not apply patches? Should we?

lib: do not access process.noDeprecation at build time

Can you add a test ?

build, tools: copy release assets to staging R2 bucket once built

I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload: ``` 09:07:10 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz s3://dist-staging/nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=nodejs-r2-dist-bucket 09:07:12 09:07:12...

build, tools: copy release assets to staging R2 bucket once built

New build: https://ci-release.nodejs.org/job/iojs+release/9924/