node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

lib: do not access process.noDeprecation at build time

Open joyeecheung opened this issue 1 year ago • 8 comments

Delay access at run time otherwise the value is captured at build time and always false.

joyeecheung avatar Jan 13 '24 00:01 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/56765/

nodejs-github-bot avatar Jan 13 '24 00:01 nodejs-github-bot

Can you add a test ?

targos avatar Jan 13 '24 08:01 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/56811/

nodejs-github-bot avatar Jan 16 '24 15:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56876/

nodejs-github-bot avatar Jan 22 '24 14:01 nodejs-github-bot

Can you add a test ?

@targos I don't think we can reliably test this because this requires accessing something that we are not supposed to access in the snapshot i.e. before the test is run.

joyeecheung avatar Jan 31 '24 16:01 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/57022/

nodejs-github-bot avatar Feb 02 '24 14:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57028/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57144/

nodejs-github-bot avatar Feb 16 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57159/

nodejs-github-bot avatar Feb 17 '24 16:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57185/

nodejs-github-bot avatar Feb 20 '24 01:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57193/

nodejs-github-bot avatar Feb 20 '24 08:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57210/

nodejs-github-bot avatar Feb 20 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57227/

nodejs-github-bot avatar Feb 21 '24 01:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57229/

nodejs-github-bot avatar Feb 21 '24 02:02 nodejs-github-bot

https://github.com/nodejs/node/issues/51813 failed across multiple PRs.

legendecas avatar Feb 21 '24 03:02 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/57256/

nodejs-github-bot avatar Feb 21 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57271/

nodejs-github-bot avatar Feb 21 '24 21:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57280/

nodejs-github-bot avatar Feb 22 '24 02:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57281/

nodejs-github-bot avatar Feb 22 '24 03:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57291/

nodejs-github-bot avatar Feb 22 '24 15:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57314/

nodejs-github-bot avatar Feb 22 '24 22:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57416/

nodejs-github-bot avatar Feb 25 '24 23:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57421/

nodejs-github-bot avatar Feb 26 '24 01:02 nodejs-github-bot

Landed in 9ac98b1a663d522008db6c0a072381892644176b

nodejs-github-bot avatar Feb 26 '24 02:02 nodejs-github-bot