Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

[v21.x backport] deps: update undici to 6.6.2

@marco-ippolito My branch is already up-to-date wrt. `v21.x-staging`

childprocess kill() results in -4048 EPERM error on windows since update to v21.6.2

@nodejs/libuv

childprocess kill() results in -4048 EPERM error on windows since update to v21.6.2

Maybe? I don't know if that would be relevant without a repro using libuv directly. FWIW this commit changed the implementation of the `uv_kill` function on Windows: https://github.com/libuv/libuv/commit/129362f35648a61ab19ab665014d2013731a986b @vtjnash

`new Intl.Segmenter().segment()` causes SEGFAULT with `--with-intl=small-icu` and no runtime ICU data

Backtrace: ``` #0 0x0000fffff68cba28 in v8::internal::JSSegments::Create(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle) () from /lib64/libnode.so.115 #1 0x0000fffff64bfee0 [PAC] in v8::internal::Builtin_SegmenterPrototypeSegment(int, unsigned long*, v8::internal::Isolate*) () from /lib64/libnode.so.115 #2 0x0000fffff6305964 [PAC] in Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit () from /lib64/libnode.so.115...

deps: update llhttp to 9.2.0

Are there notable changes?

lib: create global console properties at snapshot build time

Looks like you need to update the code owners file

deps: upgrade libuv to 1.48.0

v21.x backport: https://github.com/nodejs/node/pull/51698

Support GN build without using depot_tools

> the GN build of V8 requires the following dependencies to exist Is it an issue even though we include the source of these dependencies in our tree?

Support GN build without using depot_tools

OK for `icu`. The other ones are in the `third_party` directory.

build: fix warning in cares under GN build

This should be merged quickly after the security release.