Michaël Zasso

Results 1686 comments of Michaël Zasso

They don't strictly need it. Collaborators can still start CI jobs from Jenkins.

Isn't the main difference that V8 builds use Clang?

This is not the test runner code.

This should fix it in a non-breaking way: ```diff diff --git a/lib/buffer.js b/lib/buffer.js index a8d07342e15..904f1fff6b3 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -820,12 +820,12 @@ Buffer.prototype.toString = function toString(encoding, start, end)...

CI failed as expected: https://ci.nodejs.org/job/node-test-commit-linux-containered/41653/nodes=ubuntu2204_sharedlibs_smallicu_x64/testReport/junit/(root)/parallel/test_intl/

https://ci.nodejs.org/job/node-test-commit-linux-containered/41610/

I'll wait for https://github.com/nodejs/node/pull/51792 to rebase.