Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

deps: update V8 to 12.2

Run with `-j 4`: https://ci.nodejs.org/view/All/job/node-test-commit-aix-targos/1/nodes=aix72-ppc64/

deps: update V8 to 12.2

@sumitradawn same error with 4 parallel jobs instead of 6.

deps: update V8 to 12.2

@miladfarca Thanks, I included both commits.

Hooks loading `commonjs` files uses `import` condition for `require()`

Also a repo or something else to download is more difficult to review for malware / malicious code.

node:test APIs returning Promises clashes with no-floating-promises lint rule

There is a (documented) subtlety in Node.js API, which I believe is the source of this issue: When you call `test` inside a `describe`, you are not supposed to await...

[v18.x backport] esm: use import attributes instead of import assertions

We may also need https://github.com/v8/v8/commit/d90d4533b05301e2be813a5f90223f4c6c1bf63d

[v18.x backport] esm: use import attributes instead of import assertions

I already backported it to v20.x. What's missing is https://github.com/nodejs/node/pull/50703.

[v18.x backport] esm: use import attributes instead of import assertions

The CI failure happens with the ASan build (`./configure --enable-asan`)

[v18.x backport] esm: use import attributes instead of import assertions

I'm ready to push it to v20.x-staging with https://github.com/nodejs/node/pull/50181. See https://github.com/nodejs/node/pull/51124#issuecomment-1854138679

build: add a flag v8_enable_simulator

I don't feel qualified to review these changes, sorry.