node icon indicating copy to clipboard operation
node copied to clipboard

build: implement build android workflow

Open MeowShe opened this issue 1 year ago • 7 comments

Experimental activation of CI Workflow for building on the Android platform.

MeowShe avatar Feb 05 '24 04:02 MeowShe

Review requested:

  • [ ] @nodejs/actions

nodejs-github-bot avatar Feb 05 '24 04:02 nodejs-github-bot

All other files use the extension .yml as far as I can tell. I'd suggest renaming to build-androi.yml for consistency.

You're right, it's a mistake.

MeowShe avatar Feb 13 '24 04:02 MeowShe

  • Is there any way to try and run it before merging?
  • Is it going to block commit queue when it fails?

targos avatar Feb 13 '24 06:02 targos

  • Is there any way to try and run it before merging?

  • Is it going to block commit queue when it fails?

  1. We are waiting for another PR merge regarding Android build fixes. (#51632)

  2. This is an experimental feat., it shouldn't block commit queue even if fails.

MeowShe avatar Feb 13 '24 08:02 MeowShe

This is an experimental feat., it shouldn't block commit queue even if fails.

I know it shouldn't, but I'm afraid it will (it runs on pull_request event).

targos avatar Feb 13 '24 08:02 targos

Is it going to block commit queue when it fails?

GitHub unfortunately still does not support allowed failures (see https://github.com/actions/runner/issues/2347), but perhaps one could use continue-on-error somehow?

tniessen avatar Feb 22 '24 13:02 tniessen

We can use continue-on-error. It will make the run always green. I'm still sceptical about having feedback on all pull requests for a very experimental target. A new actions run will use a worker from the pool and add a pending check to the pull request while it runs.

targos avatar Feb 22 '24 13:02 targos

@tniessen @targos continue-on-error has been used already(dea50f6f4e986a907f2353028eed77987876decf).

MeowShe avatar Feb 23 '24 02:02 MeowShe

I'm still sceptical about having feedback on all pull requests for a very experimental target.

A new actions run will use a worker from the pool and add a pending check to the pull request while it runs.

The main purpose of this pull request is to advance the official support of Node.js for the Android platform. Once the goal is achieved and it becomes stable, this check should become mandatory.

MeowShe avatar Feb 25 '24 06:02 MeowShe

I'm still sceptical about having feedback on all pull requests for a very experimental target.

Perhaps in the short term having it be a path-based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs.

bnb avatar Feb 26 '24 14:02 bnb

Maybe label is a better idea? We label PRs when if it fit to run Android build test.

MeowShe avatar Feb 27 '24 04:02 MeowShe

path based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs.

I guess there doesn't seem to be a clear definition of paths, we don't know what paths are available to run Android build tests in particular.

MeowShe avatar Feb 27 '24 04:02 MeowShe