Tamir Duberstein

Results 362 comments of Tamir Duberstein

Seems there are lint failures.

> @tamird, i could write a small helper function to check if bpf is enabled in lsm config through sysfs api. Should i put this function in the lsm test...

Surely you can read the logs? ``` ---- tests::lsm::lsm stdout ---- thread 'tests::lsm::lsm' panicked at test/integration-test/src/tests/lsm.rs:17:10: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No...

Doesn't sound like a sensible approach since it doesn't exist in any of the virtualized tests either, meaning we'd not be running these new tests at all. Perhaps @dave-tucker knows...

No action needed for now, @vadorovsky and I are trying to figure out LSM tests in #1359 before I get back to this.

I reported a related problem [here](https://lore.kernel.org/all/CAJ-ks9=ztzVopy2w1ggR+-xAyc_CigGWKn4vVDy1sWoMQUUaSg@mail.gmail.com/#u). The solution there would be the same: manually edit the tag.

Notably 1.25 has [`synctest`](https://pkg.go.dev/testing/synctest).

Jeez that's frustrating behavior from the LLVM apt maintainers.

@gregestren could you please have a look at this and #123? The motivation between these two is very similar, and I'd like to follow @avrabe's lead on the proper way...