Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

doc(aya): document tcx link pinning for atomic program replacement

Could you address the CI failures?

doc(aya): document tcx link pinning for atomic program replacement

Yep #1409 should fix it

doc(aya): document tcx link pinning for atomic program replacement

@codex review

Changes to `aya-log-ebpf` made it impossible(?) to define our own `Error` type

Sounds like you can have a trait method that returns a `&'static str` and log that in the usual way?

Changes to `aya-log-ebpf` made it impossible(?) to define our own `Error` type

I'm surprised to hear stack size is a problem. It's not possible to make use of Display impls unfortunately because aya-log-ebpf needs more information than that trait exposes.

Changes to `aya-log-ebpf` made it impossible(?) to define our own `Error` type

My best guess is you were already close to the stack limit and the string headers pushed you over the limit. It's also possible the logging implementation uses more stack...

Changes to `aya-log-ebpf` made it impossible(?) to define our own `Error` type

https://chatgpt.com/s/t_68d24720864081918ede0214fc384353

aya-ebpf: Add BTF map definitions for hash maps

@codex review

🐛 Add missing `ValidationException.str` functionality

Hi @svlandeg, turns out there is already a test, it was just too permissive. I have tightened it up and fixed the implementation to make it pass.

🐛 Add missing `ValidationException.str` functionality

@svlandeg are you able to merge this please?