Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

refactor: use `target_arch = "bpf"` for `panic_handler`

Here and in the main repo: the commit message should include all the information, including why. Please refrain from anemic commit messages with rich PR text - the commit is...

refactor: use `target_arch = "bpf"` for `panic_handler`

> The CI error seems unrelated to my change :( The failures on macos are indeed unrelated, but the others definitely are. I see: ``` + cargo +nightly clippy --package...

Rehabilitate CI, upgrade to syn@2

@TeXitoi I think you might need to enable github actions from the repo settings.

uprobe offset for dynamic shared library not adjusted for ELF file `.text` section offset

Can you share the relevant code from your program please?

uprobe offset for dynamic shared library not adjusted for ELF file `.text` section offset

Aya already implements the offset logic you describe but only when the attachment point is given relative to a symbol name. See https://github.com/aya-rs/aya/blob/3edac6153e7f6a66e6e05a4b4dd8625d98533c13/aya/src/programs/uprobe.rs#L51-L61 When you pass an integer, it is...

uprobe offset for dynamic shared library not adjusted for ELF file `.text` section offset

That sounds reasonable. Would you like to work on a PR?

fix: c_void enum in BTF

This PR has 22 commits. Please squash this to an appropriate number of commits, each with a sensible commit message.

fix: c_void enum in BTF

Sorry for letting this sit. Kernel 5.4 is quite old, and we don't have test coverage for it in aya. Can you help me understand that use case? I [recently](https://github.com/aya-rs/aya/pull/1251)...

docs: update LSM hook prompt to reference lsm_hook_defs.h

Yes, just one path please and then this is good to go. Thanks!

Don't enforce superfluous-parens for default function values

It would also be good to add an option to allow superfluous parens preceding negation. ```diff - if not (MIN