Tamir Duberstein
Tamir Duberstein
It's a dev dependency, why do you need to use it?
No, it's not used, regardless of profile. It is only used when building the tests. Are you doing that? Do you need to?
I don't think that comment is the important part. https://github.com/aya-rs/bpf-linker/commit/615898266856655d7a438811f8f5628bbf4e2126
FYI https://github.com/aya-rs/bpf-linker/pull/316 changed the interface for packagers - you'll now need to set `$BPFEL_SYSROOT_DIR`.
Given the concerns about `&CStr` becoming a thin pointer, I think my PR is a no-go. Would the next logical step be to open a PR implementing `Display` for `CStr`...
@BurntSushi thanks. Are more sign offs required? The [feature lifecycle doc](https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html) describes tracking issues as tracking feature stabilization, but since this would be insta-stable, I presume the tracking issue would...
While not stable, `impl Display for ByteStr` is also lossy. Does that mean `ByteStr` will need to move to a `display` method? cc @joshtriplett
This was approved 2 weeks ago. What stands in the way of it being merged?
We're a long time away from LLVM 18, closing this as no longer relevant. Please let me know if it's still relevant!