Tamir Duberstein
Tamir Duberstein
@alejsdev could you please take a look? This is relatively trivial and contains a test as requested by @svlandeg.
Hello! This is ready for review.
@tiangolo your points are well taken. The last comment here was 5 weeks ago.
@YuriiMotov I've implemented the changes you suggested. Note that there is no test coverage for the `ResponseValidationError.__str__` behavior you asked to preserve; you might consider adding some in another PR....
I think the proper thing to do is just to avoid importing exceptions from compat. That would require moving a bit of code from company into exceptions. Would you like...
@YuriiMotov FYI I decided to hold off on #11542 until this is merged. Let me know how you'd like to proceed.
@YuriiMotov looks like the controversial changes were easy to remove now that #14168 has landed.
> Looks like it's not so easy now as we run tests on Python 3.12 and Pydantic V1 is not supported there.. Just needed a little copy & paste.
> @tamird, thanks for resolving the merge conflict! > > If I recall correctly, previously we switched to using existing `ErrorDict` and `display_errors` (import them from `pydantic.v1`) for simplicity. But...
Should we just talk to ChatGPT directly? 🙂