Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

Add `llvm-install-name-tool`

Hm. I wasn't even aware of that codepath. I need to rewrite the [`pdfium`](https://github.com/bblanchon/pdfium-binaries/releases) dylib.

Rename output of -ebpf crate

Can you add doc generation to CI so we can ensure it doesn't break?

Rename output of -ebpf crate

@miniduikboot can you address @ErrorTeaPot's comment?

Rename output of -ebpf crate

I think rename the library makes sense. How come you added `| snake_case` in just one place? I think you need to rebase to clear the test failures. cc @vadorovsky

Rename output of -ebpf crate

Ah it seems a real issue caused by this change. The panic handler is now defined twice (lib and bin)

Ah, it's because of unification. See https://github.com/aya-rs/aya/commit/3078e5aba085cc690556c7f3437fb4f2fa4831ed. `sk_msg` is the only variant that uses the `common` crate. https://github.com/aya-rs/aya-template/blob/0158e1b8e0d60c18546b08f2879992d8294e3feb/%7B%7Bproject-name%7D%7D-ebpf/src/main.rs#L116-L123

Tamir Duberstein

Add `llvm-install-name-tool`

Rename output of -ebpf crate

Rename output of -ebpf crate

Rename output of -ebpf crate

Rename output of -ebpf crate

Rename output of -ebpf crate

Fix TODOs of unwrap calls by implementing Error Variants

Fix TODOs of unwrap calls by implementing Error Variants

ebpf: add bpf_d_path helper function

Add branch override for cloud exec git reference