toasted-marshmallow icon indicating copy to clipboard operation
toasted-marshmallow copied to clipboard
verified publisher icon lyft

[POC] Inject via marshaller and unmarshaller

Open taion opened this issue 8 years ago • 4 comments

This PR demonstrates injecting the JIT without adding any explicit hooks in Marshmallow. The tests in this test suite all pass, but I didn't patch the upstream vendored tests, as the configuration mechanism is now different.

This allows eliminating the custom Marshmallow fork.

taion avatar Apr 20 '18 23:04 taion

Oops, accidentally deleted the branch. Didn't mean to do that. This PR is still as intended.

taion avatar Apr 20 '18 23:04 taion

Got the benchmarks working too.

I'm not sure how to run the Marshmallow test suite with this API, though. I'm sure I could figure something out.

Still, how does this approach look? This seems easier to integrate, as it removes the "must uninstall Marshmallow" requirement.

taion avatar Apr 20 '18 23:04 taion

@rowillia Any thoughts here?

taion avatar May 13 '18 14:05 taion

@rowillia Ping! Does this seem like an interesting avenue to pursue?

taion avatar Aug 16 '18 18:08 taion