Taiki Endo

Results 938 comments of Taiki Endo

It should already be possible to do this by calling the changelog generator and saving the output to a file before calling this action, and then specifying that path in...

I think it is okay to provide the ability to preserve the generated lock file, but as said in #18, providing the ability to just generate a lock file is...

BTW, if there is no existing Cargo.lock, the cargo-minimal-versions already works that way.

Currently, this action only supports creating a new release or overwriting an existing release (https://github.com/taiki-e/create-gh-release-action/issues/5), but I'm okay with adding support for updating an existing release. That said, the following...

- `cargo minimal-versions` forwards flags to cargo, so it may be possible to support custom subcommands on *the wasm-pack side*. - I'm not sure how realistic it would be to...

https://github.com/tokio-rs/mio/issues/957

1\. will be fixed in #44, 2\. and 4\. will be fixed in #45.

> A difficulty is finding a portable way to enable/disable interrupts. Sadly, `portable-atomic` doesn't expose anything of the sort publicly. AFAIK [critical-section](https://github.com/rust-embedded/critical-section) crate is often used in rust-embedded and its...

> enable/disable interrupts To be clear: Both critical-section and portable-atomic actually implement (or require the user to implement) this as disable-interrupts/restore-interrupts-state, not disable-interrupts/enable-interrupts. This is one of the requirements for...

> the problem is that its difficulty to write the spin-rs IrqMutex implementation to pass throu the user implementation Um, I'm sorry, I thought you needed the equivalent of using...