Taiki Endo comments

Results 938 comments of


                                            Taiki Endo

Distributed release files can only compile for musl

Filed #365 to fix this.

Fails under cargo nextest

This is kind of a side effect of https://github.com/eupn/macrotest/pull/69. That said, since the target directory is shared, it should not work to actually run macrotest in parallel anyway due to...

Any way to upload files with this action?

This seems to make sense to me. I think we can implement this by just copying the code around the `asset` input option in the `upload-rust-binary-action`.

Any way to upload files with this action?

I would accept a PR to implement this.

Support trait or implementation-only attributtes like `tracing::instrument`

I would like to accept a PR to add such options (trait_only/impl_only). (As for the option names, *_only is not much clear what it means, *_attr would be better)

const impls

I would accept a patch to support this. fwiw, easy-ext has parsing code for impl blocks, which we may be able to reuse. https://github.com/taiki-e/easy-ext/blob/main/src/ast.rs

It seems that external process can modify `Cargo.lock` during run of `check` action

Well, it is a known problem that r-a does not interact well with cargo commands running simultaneously in the terminal. (There are several cases, but target directory conflicts are maybe...

It seems that external process can modify `Cargo.lock` during run of `check` action

> Is there any way to delay r-a from executing cargo-metadata? As another way, if we can avoid cargo-metadata changing the lockfile, we can also fix this problem, because the...

Option to disallow override of release

There are 4 possible strategies here. - If a release already exists, overwrite it. (current behavior) - If a release already exists, exit with an error. - If a release...

Take changelog verbatim from command output?

Assuming the patch is not too complicated, I'm open to accepting a patch that adds another way to get the changelog.